Add contextvar support #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. Would you add add a unittest for this code? |
youknowone
reviewed
Jun 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=========================================
- Coverage 97.98% 96.4% -1.58%
=========================================
Files 14 14
Lines 1387 1390 +3
=========================================
- Hits 1359 1340 -19
- Misses 28 50 +22 |
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 97.98% 97.99% +0.01%
==========================================
Files 14 14
Lines 1387 1392 +5
==========================================
+ Hits 1359 1364 +5
Misses 28 28 |
youknowone
reviewed
Jun 29, 2019
youknowone
reviewed
Jun 29, 2019
youknowone
approved these changes
Jun 30, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for contextvar.ContextVar
Fixes: #135