Don't provide a service when the getter throws an error

[rdallasgray]

In the case where I have an external service which may not be ready (say it has to be loaded asynchronously), I want to throw an error:

bottle.factory("asyncService", function(container) {
    var service = window.asyncService;
    if (service === undefined) {
        throw new Error("Service is not loaded");
    }
    return service;
}

The present behaviour, on getting container.asyncService will throw the error once, and then afterwards return undefined. Even if the service resolves at some point, the result of container.asyncService will always be undefined after the initial call.

This changes the behaviour so as to throw the error until the service resolves, and then behave as before. The use case is that I have services dependent on another service which is not ready until after bottle.resolve() has been called. I want to fail fast if anything tries to access that service before then.

It's a super-simple change in the code which just involves changing the order of when property names are deleted from the container vs when $get is called.

[rdallasgray]

Updated per comments in https://github.com/geome/bottlejs/commit/778692b6664360ecae05e547a7366b24c4f95557#commitcomment-14764665

[young-steveo]

This is now in release 1.2.1

[rdallasgray]

Hey, that's great Steven, many thanks.

Have a good Christmas and New Year!