-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply-manifest does not perform filesystem operations #268
Comments
dmerejkowsky
added a commit
that referenced
this issue
Nov 24, 2020
Workspace instances are now built with a WorkspaceConfig and LocalManifest instances. LocalManifest is abstract and is either implemented by: * ClonedManifest, which represents a manifest cloned in <workspace_path>/.tsrc/manifest, * or ManifestCopy, which represents a manifest located in the file system This allows for a more robust implementation of the `apply-manifest` command Fix #268
dmerejkowsky
added a commit
that referenced
this issue
Nov 24, 2020
Workspace instances are now built with a WorkspaceConfig and LocalManifest instances. LocalManifest is abstract and is either implemented by: * ClonedManifest, which represents a manifest cloned in <workspace_path>/.tsrc/manifest, * or ManifestCopy, which represents a manifest located in the file system This allows for a more robust implementation of the `apply-manifest` command Fix #268
dmerejkowsky
added a commit
that referenced
this issue
Nov 24, 2020
Workspace instances are now built with a WorkspaceConfig and LocalManifest instances. LocalManifest is abstract and is either implemented by: * ClonedManifest, which represents a manifest cloned in <workspace_path>/.tsrc/manifest, * or ManifestCopy, which represents a manifest located in the file system This allows for a more robust implementation of the `apply-manifest` command Fix #268
dmerejkowsky
added a commit
that referenced
this issue
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
symlink
operationtsrc apply-manifest
Note: this is because of this code:
We override
workspace.repos
but instead we should do something like:and override the
local_manifest
instance of the workspace.This needs a bit of refactoring, for instance by having an abstract LocalManifest class, which would be implemented by ClonedManifestRepo and ManifestPath or something ....
The text was updated successfully, but these errors were encountered: