dm/config-refactor #185
Merged
dm/config-refactor #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=========================================
Coverage ? 83.51%
=========================================
Files ? 30
Lines ? 1650
Branches ? 199
=========================================
Hits ? 1378
Misses ? 223
Partials ? 49 |
Closed
dmerejkowsky
force-pushed
the
dm/config-refactor
branch
3 times, most recently
from
33795d0 to
4a15ce9
Compare
Turns out we don't really need it - the logic to use all elements from the group list belongs to higher-level code like the `sync` or `foreach` implementation
Do not use `gitlab` and `github_enterprise` nested classes, just use `gitlab_url` and `github_enterprise_url` attributes. Also, get rid of the named types in tsrc/manifest.py - one of them (ManifestConfig) had the same name as an other class! If anything, we should use TypedDict instead Finally, rename vague `.load()` method into `apply_config()`
LocalManifest class:
* no longer hold any configuration, and only knows how to
update the manifest clone in <workspace>/.tsrc/manifest. All configuration
attributes are now managed by the WorkspaceConfig class
* rename confusing `manifest` property into a `get_manifest()` method
Workspace class:
* contains a LocalManifest and a WorkspaceConfig instance.
* instead of having to call `load_manifest`, the config file in
`<workspace>/.tsrc/config.yml` is parsed in Workspace ctor
* remove some delegation methods that were reading config from
self.local_manifest and either use
- self.config or
- self.local_manifest.get_manifest()
Also, no longer handle local manifest commit from a *path* and not an url, and
get rid of the concept of a manifest *tag* altogether.
Finally, get rid of the confusing "active_groups" naming. It's now in WorkspaceConfig.repo_groups
which is hopefully a better location and nome.
* `tsrc init` can now only be called once, and always with an URL * Get rid of the `--file` option
Instead of running `init` twice, we need too check what happens when we change the manifest branch in the workspace config.
Before: tsrc init --group foo --group bar After: tsrc init --groups foo bar
This adds links from the doc to the GitHub repo, and also an "Edit this page on GitHub" link, which is nice :)
dmerejkowsky
force-pushed
the
dm/config-refactor
branch
from
4a15ce9 to
55bb73a
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #178
Fix #179
Fix #180
Fix #181