-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adguard preprocessor directive to load sublist only when using Adguard iOS App [2020-09-08: Adguard Android App Exclusion List Added] #241
Comments
Unknown if this will cause error in uBO (hopefully the sublist will just get ignored) as `adguard_app_ios` is not a [supported directive](https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#if-condition) in uBO. [adguard Directive list](https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#what-constants-we-declare) Relates to #241
Unknown if this will cause error in uBO as `adguard_app_ios` is not a [supported directive](https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#if-condition) in uBO. (The sublist should be ignored entirely but based on testing, it still loads the filters/adguard_mobile_exclusion_filters.txt so adding the pre-processor directive within the sublist as well [adguard Directive list](https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#what-constants-we-declare) Relates to #241
In uBO the sublist should be ignored entirely but based on testing, logger shows the
|
The uBO fix to recognize the directive |
How this works with something like:
in file
|
uBO only allows ONE preprocessor directive, no match for two cases with |
AdGuard has its own internal system that converts uBO syntax to AdGuard syntax, I don't think these filters get thrown out, just rewritten internally. |
I mean, if I don't have to reprogramme this preprocessor, so that some 5 thousand filters won't suddenly disappear from the list of active filters in uBO, under AdGuard such exclusion works well for now. AdGuard has a strange policy - filters do not for iOS / Content Blocker convert in CSS (instead use preprocessors):
So instead of adding thousands |
I've Added an Adguard App for Android exclusion list now Discussion: AdguardTeam/AdguardFilters#63209 (comment) Related: #67 |
Describe the issue
I would like to use exclusion filters in a sublist that will only get loaded when the client is detected to be adguard on iOS to workaround cosmetic display issues caused by CSS style modification "companion" filters that end up incorrectly removing extra spacing/content that doesn't work because iOS can't use CSS style modification filters so the companion filters for the CSS Style modification filters are not necessary and should be excluded.
In ultralist.txt I tried using the pre-processor directive as I follow the logic but it doesn't appear to work and get loaded properly into Adguard for iOS.
Related to AdguardTeam/AdguardBrowserExtension#917
I need to investigate further to find out why the sublist is not being loaded on Adguard iOS compiled list when subscribed to Web Annoyances Ultralist in the 'Annoyances' section of Adguard.
The text was updated successfully, but these errors were encountered: