[2.2.0rc1] undefined isOpera and isIE

[krikunts]

Autocomplete is boken in 2.2.0rc1 since 61e54ee because of undefined variables isOpera and isIE in autocomplete.js
Lines 63 and 67
Lines 82 and 86

As @jpic said it should be backported from django admin, probably from here

[jpic]

Yep undef variable are easy to fix if you make a PR it will get in
Le 26 mai 2015 19:43, "Tatiana" notifications@github.com a écrit :

Autocomplete is boken in 2.2.0rc1 since 61e54ee
61e54ee
because of undefined variables isOpera and isIE in autocomplete.js
Lines 63 and 67

django-autocomplete-light/autocomplete_light/static/autocomplete_light/autocomplete.js

Lines 62 to 68 in 0f58157

	while (obj.offsetParent) {
	curleft += obj.offsetLeft - ((isOpera) ? 0 : obj.scrollLeft);
	obj = obj.offsetParent;
	}
	// IE offsetParent does not include the top-level
	if (isIE && obj.parentElement){
	curleft += obj.offsetLeft - obj.scrollLeft;

Lines 82 and 86
https://github.com/yourlabs/django-autocomplete-light/blob/master/autocomplete_light/static/autocomplete_light/autocomplete.js#L82-L86

As @jpic https://github.com/jpic said it should be backported from
django admin, probably from here
https://github.com/django/django/blob/25e06bca57c068d4b9e9b4221b16a667ccb0d38e/django/contrib/admin/static/admin/js/core.js#L4-L5

—
Reply to this email directly or view it on GitHub
#425.

[blueyed]

FWIW, we should have test coverage for JS that would happen.
See e.g. http://stackoverflow.com/questions/4189312/capturing-javascript-error-in-selenium.

[jpic]

I know that is why we should release our js as standalone jq plug-in
Le 26 mai 2015 22:27, "Daniel Hahler" notifications@github.com a écrit :

FWIW, we should have test coverage for JS that would happen.
See e.g.
http://stackoverflow.com/questions/4189312/capturing-javascript-error-in-selenium
.

—
Reply to this email directly or view it on GitHub
#425 (comment)
.

[jpic]

This should be fixed in 2.2.0rc2

[jpic]

Could you confirm this is fixed in current rc and close the issue ?

Thanks a lot @lucky-user

[krikunts]

Closing as it's fixed in e61e8f0