Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer mousedown and specify input #409

Merged
merged 2 commits into from
May 17, 2015
Merged

Prefer mousedown and specify input #409

merged 2 commits into from
May 17, 2015

Conversation

SebCorbin
Copy link
Contributor

Hello,
Thanks to your amazing package I've been able to fulfill my most advanced UX desires, you made some nice work here :)

Although I've found two small things that bothered me:

  1. Prefering mousedown instead of click event allows to work on data already processed by autocomplete
  2. I've used readonly inputs in my choice template, but they get picked up at initialisation, so I needed to specify the original input

Mousedown fires before blur, allowing to treat the new data on blur
@jpic
Copy link
Member

jpic commented May 15, 2015

But click is touch-compatible wheras mousedown is not am I correct ?

@jpic jpic added this to the 2.2.0 milestone May 15, 2015
@jpic
Copy link
Member

jpic commented May 17, 2015

Touch suport is handled by #418 , merging.

jpic added a commit that referenced this pull request May 17, 2015
Prefer mousedown and specify input
@jpic jpic merged commit dc9d846 into yourlabs:master May 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants