Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the primary key name from choices so does not have to be id #412

Closed
wants to merge 3 commits into from

Conversation

mhuailin
Copy link
Contributor

@mhuailin mhuailin commented May 5, 2015

Right now if you attempt to use autocomplete-light on a table where the primary key is not id, you get a id field error.

@mhuailin mhuailin closed this May 5, 2015
@mhuailin mhuailin reopened this May 5, 2015
@jpic jpic added this to the 2.2.0 milestone May 15, 2015
@jpic
Copy link
Member

jpic commented May 17, 2015

Closing in favor of #417, which contains your PR + some tests.

@jpic jpic closed this May 17, 2015
jpic added a commit that referenced this pull request May 18, 2015
Fix #412: Support models with a pk different than "id" and non-numeric.
@jpic
Copy link
Member

jpic commented May 26, 2015

Could you try with 2.2.0rc1 which was released yesterday ?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants