Grid select support singleSelect #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngBrain1893
force-pushed
the
feature/grid-single-select
branch
from
f7d0eb6
to
e0d14f8
Compare
React 16.x 的某个版本改变了元素 所以 Grid disabled reason 展示的功能失效了 |
cpylua
reviewed
Jan 20, 2021
cpylua
reviewed
Jan 20, 2021
cpylua
reviewed
Jan 20, 2021
cpylua
reviewed
Jan 20, 2021
cpylua
reviewed
Jan 20, 2021
cpylua
reviewed
Jan 20, 2021
cpylua
reviewed
Jan 20, 2021
cpylua
reviewed
Jan 20, 2021
cpylua
reviewed
Jan 20, 2021
1. 添加废弃属性注释 2. 调整 demo 3. 调整 checkbox/radio 包裹元素 cls
youngBrain1893
force-pushed
the
feature/grid-single-select
branch
from
04cd66b
to
993c365
Compare
youngBrain1893
force-pushed
the
feature/grid-single-select
branch
from
993c365
to
18e748a
Compare
cpylua
suggested changes
Jan 21, 2021
Comment on lines
51
to
61
| // 等重构再删了吧，改不动 | ||
| // eslint-disable-next-line react/no-deprecated | ||
| componentWillReceiveProps( | ||
| nextProps: IGridSelectionRadioProps, | ||
| nextState: IGridSelectionRadioState | ||
| ) { | ||
| const checked = this.getCheckState(nextProps); | ||
| if (checked !== nextState.checked) { | ||
| this.setState({ checked }); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes you made in this pull request:
props.selection废弃getCheckboxProps对应调整为getSelectionPropsCloses #1643