Integrate with the lifetime Event Loop #34
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With one evloop per context, we don't need to remember which scheduler is waiting on the evloop. We just need to know that one is waiting and to interrupt the evloop in that case.
We reach that method when we: 1. start a thread; 2. start the main thread run loop fiber; 3. resume the run loop fiber. In every case the local queue is necessarily empty, otherwise we wouldn't have resumed the run loop. Any parallel enqueue is coming from the global queue, which is immediately checked, then it should spin.
Same reasoning as for ST.
Fixes a bunch of issues caused by evloop#run enqueueing fibers while we're running the evloop, which led to many enqueues for ST that could be replaced with a single bulk enqueue (simpler, faster) as well as properly handling trying to wake up a thread for MT (and not try to interrupt the currently running evloop, or no wakeup because a spinning thread is running the evloop, ...)
It seems to be creating parallelism issues with the GC instead of fixing them.
ysbaddaden
force-pushed
the
feature/lifetime-event-loop
branch
from
6561ccc
to
c31cca3
Compare
This was
linked to
issues
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.