Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed option --vsync-aggressive #141

Closed
Rosalie241 opened this issue Mar 24, 2019 · 13 comments
Closed

Removed option --vsync-aggressive #141

Rosalie241 opened this issue Mar 24, 2019 · 13 comments
Labels
info requested The developers have requested additional information from the reporter user config Problem is in user's configuration/setup

Comments

@Rosalie241
Copy link

Rosalie241 commented Mar 24, 2019

Platform

Arch Linux

Environment

Openbox

Compton version

> ~ compton --version
v6
> ~ 

Steps of reproduction

My autostart:

# Shadows and vsync
compton --vsync-aggressive &

I updated today and noticed that it isn't working anymore, it seems like the option has been removed?

Expected behavior

It should work like normally

Current Behavior

it just shows

> ~ compton --vsync-aggressive
compton: unrecognized option '--vsync-aggressive'

Why was it removed? It used to work fine

I couldn't find anything about it in the github issues, so I opened this issue.

@Rosalie241
Copy link
Author

I discovered this: #130

however, when I try compton --vsync I still have screen tearing,

I'm on nVidia and have ForceFullCompositionPipeline set, however I still need --vsync-aggressive to fix all the tearing.

@Ropid
Copy link

Ropid commented Mar 24, 2019

In man compton, there's an option --xrender-sync-fence mentioned:

--xrender-sync-fence
Use X Sync fence to sync clients' draw calls, to make sure all draw calls are finished before compton starts drawing. Needed on nvidia-drivers with GLX backend for some users.

Perhaps try adding it to your compton command line together with --backend glx.

@yshui
Copy link
Owner

yshui commented Mar 24, 2019

@tim241

  1. What setup do you have? Graphic card? How many monitors? Refresh rate?
  2. Which backend are you using? glx or xrender?
  3. What kind of tearing are you talking about?

@yshui yshui added the info requested The developers have requested additional information from the reporter label Mar 24, 2019
@Rosalie241
Copy link
Author

@yshui

Setup

1x GTX 1050 2gb with driver version 418.56
1x 1080p 60 hertz monitor

Backend

the default one when using --vsync

Tearing

General screen tearing when switching workspace/watching youtube videos that I normally dont have when using --vsync-aggressive

Extra

my intent when making this issue was rather to notify you that it broke my setup, I distro hop at times and not all distros switched to your fork, I'd like to request for the option to be re-added since it worked fine?

@yshui
Copy link
Owner

yshui commented Mar 25, 2019

If you don't specify the backend, you are using the xrender backend. And vsync doesn't work with the xrender backend. It is pure luck that it worked for you before, it could have been broken by anything.

If you want vsync, please use --backend glx.

@yshui yshui added the user config Problem is in user's configuration/setup label Mar 25, 2019
@Rosalie241
Copy link
Author

Alright, that works, thanks ❤️

@Rosalie241
Copy link
Author

huh, after restarting X and rebooting, the tearing is back (yes, it's in the autostart)

@Rosalie241 Rosalie241 reopened this Mar 25, 2019
@yshui
Copy link
Owner

yshui commented Mar 25, 2019

@tim241 Put backend = "glx" in your config file.

@Rosalie241
Copy link
Author

I used compton --vsync --backend glx and I also tried compton --backend glx --vsync

@Rosalie241
Copy link
Author

I don't have a config file, I don't want to make one either.

@yshui
Copy link
Owner

yshui commented Mar 25, 2019

Can you make sure that you set up autostart correctly?

@Rosalie241
Copy link
Author

alright, just tested it again and it seems to work now weirdly enough. Thanks again ❤️

@yshui
Copy link
Owner

yshui commented Mar 25, 2019

@tim241 Feel free to reopen it if it happens again. Vsync should work with NVIDIA driver + glx backend. If it doesn't it would be really weird. So be sure to check if your command line flags are actually passed to compton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info requested The developers have requested additional information from the reporter user config Problem is in user's configuration/setup
Projects
None yet
Development

No branches or pull requests

3 participants