vsync: choose vsync method automatically #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choose the best vsync method for the user, instead of asking them to frustratingly try every one of the options to see what works. With this commit, the `vsync` option will take only a boolean value. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
yshui
changed the title
JohnAZoidberg
added a commit
to JohnAZoidberg/nixpkgs
that referenced
this pull request
May 18, 2019
vsync is now a boolean option, see: yshui/picom#130 menu-opacity is deprecated and there's a warning that says: Please use the wintype option `opacity` of `popup_menu` and `dropdown_menu` instead.
| } | ||
| #endif | ||
| #ifdef CONFIG_VSYNC_DRM | ||
| log_warn("The DRM vsync method is deprecated, please don't enable it."); |
There was a problem hiding this comment.
This warning is always shown, even when vsync is disabled. Is that on purpose?
I think with the new boolean option these warning don't need to be shown.
There was a problem hiding this comment.
This is intentional, users shouldn't enable the DRM vsync method (which is a build time option) unless there is really good reason.
pull bot
pushed a commit
to milibopp/nixpkgs
that referenced
this pull request
May 28, 2019
* compton-git: 5.1-rc2 -> 6.2 vsync is now a boolean option, see: yshui/picom#130 menu-opacity is deprecated and there's a warning that says: Please use the wintype option `opacity` of `popup_menu` and `dropdown_menu` instead. * nixos/compton: Keep vSync option backwards compatible The new upstream option tries to make the best choice for the user. Therefore the behaviour should stay the same with this backwards compatibility patch. * compton-git: Remove DRM option It's deprecated and shouldn't be used. https://github.com/yshui/compton/pull/130/files#r285505456 * compton-git: Remove new_backends option Was removed in "Let old/new backends co-exist" b0c5db9f5aa500dc3568cc6fe68493df98794d4d * compton: 0.1_beta2.5 -> 6.2 Drop the legacy, unmaintained version and use the fork for real.
evanjs
added a commit
to evanjs/nixos_cfg
that referenced
this pull request
May 30, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose the best vsync method for the user, instead of asking them to
frustratingly try every one of the options to see what works.
With this commit, the
vsyncoption will take only a boolean value.Signed-off-by: Yuxuan Shui yshuiv7@gmail.com