-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compton: 0.1_beta2.5 -> 6.2 #61681
compton: 0.1_beta2.5 -> 6.2 #61681
Conversation
vsync is now a boolean option, see: yshui/picom#130 menu-opacity is deprecated and there's a warning that says: Please use the wintype option `opacity` of `popup_menu` and `dropdown_menu` instead.
0b0ed47
to
fd3558b
Compare
The new upstream option tries to make the best choice for the user. Therefore the behaviour should stay the same with this backwards compatibility patch.
fd3558b
to
1bcd9b1
Compare
It's deprecated and shouldn't be used. https://github.com/yshui/compton/pull/130/files#r285505456
Was removed in "Let old/new backends co-exist" b0c5db9f5aa500dc3568cc6fe68493df98794d4d
The module is using the old IMHO we should keep only the maintained fork from |
Yes, that seems reasonable. |
Add an alias |
Drop the legacy, unmaintained version and use the fork for real.
255662e
to
0ece8a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change (and the measures to retain backwards compatibility) seem fine 👍
Tested against my local compton config (which is basically the default config with two opacity rules).
Ah nice to have a feedback from an actual compton user, thanks @Ma27 |
On a related note, I'm excited for yshui/picom#32 |
Effectively breaks some configs since compton doesn't seem to take well of duplicate settings ( |
Oh you mean if you have |
The idea in NixOS/rfcs#42 would solve this rather well |
Yes, for example in wintypes:
{
tooltip = { fade = true; shadow = true; opacity = 0.75; focus = true; full-shadow = false; };
dock = { shadow = false; }
dnd = { shadow = false; }
popup_menu = { opacity = 0.8; }
dropdown_menu = { opacity = 0.8; }
}; |
Motivation for this change
Many new releases:
Maintainers: @ertes @Enzime @Twey
Things done
I'm using it with the NixOS module and its default settings. Seems fine so far, running all day today.
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)