Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compton: 0.1_beta2.5 -> 6.2 #61681

Merged
merged 5 commits into from
May 28, 2019
Merged

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented May 18, 2019

Motivation for this change

Many new releases:

Maintainers: @ertes @Enzime @Twey

Things done

I'm using it with the NixOS module and its default settings. Seems fine so far, running all day today.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vsync is now a boolean option, see:
yshui/picom#130

menu-opacity is deprecated and there's a warning that says:
Please use the wintype option `opacity` of `popup_menu` and
`dropdown_menu` instead.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 18, 2019
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels May 18, 2019
The new upstream option tries to make the best choice for the user.
Therefore the behaviour should stay the same with this backwards
compatibility patch.
Was removed in "Let old/new backends co-exist"
b0c5db9f5aa500dc3568cc6fe68493df98794d4d
@c0bw3b
Copy link
Contributor

c0bw3b commented May 20, 2019

The module is using the old compton and not compton-git by default?
I guess it will be hard to maintain a common module if they start using distinct options...

IMHO we should keep only the maintained fork from yshui repo and call it compton
It's already the source for compton pkg in Arch / Mageia / Void for example.

@JohnAZoidberg
Copy link
Member Author

JohnAZoidberg commented May 20, 2019

Yes, that seems reasonable.
I checked that the new derivation is exactly the same as the previous compton-git - only pname is different. With that at its old value it doesn't rebuild.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 20, 2019

Add an alias compton-git = compton to avoid breaking existing users' configs

Drop the legacy, unmaintained version and use the fork for real.
@JohnAZoidberg JohnAZoidberg changed the title compton-git: 5.1-rc2 -> 6.2 compton: 0.1_beta2.5 -> 6.2 May 24, 2019
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change (and the measures to retain backwards compatibility) seem fine 👍

Tested against my local compton config (which is basically the default config with two opacity rules).

@c0bw3b
Copy link
Contributor

c0bw3b commented May 28, 2019

Ah nice to have a feedback from an actual compton user, thanks @Ma27

@c0bw3b c0bw3b merged commit eccb90a into NixOS:master May 28, 2019
@infinisil
Copy link
Member

On a related note, I'm excited for yshui/picom#32

@JohnAZoidberg JohnAZoidberg deleted the compton-git-6.2 branch May 28, 2019 14:53
@eadwu
Copy link
Member

eadwu commented May 28, 2019

Effectively breaks some configs since compton doesn't seem to take well of duplicate settings (wintypes).

@JohnAZoidberg
Copy link
Member Author

JohnAZoidberg commented May 29, 2019

Oh you mean if you have wintypes in your extraConfig?
What do you have there?
It would be fixed if we add extraWintypesConfig?

@infinisil
Copy link
Member

The idea in NixOS/rfcs#42 would solve this rather well

@eadwu
Copy link
Member

eadwu commented May 29, 2019

Yes, for example in compton.sample.conf from the repository. extraWintypesConfig would fix it.

wintypes:
{
  tooltip = { fade = true; shadow = true; opacity = 0.75; focus = true; full-shadow = false; };
  dock = { shadow = false; }
  dnd = { shadow = false; }
  popup_menu = { opacity = 0.8; }
  dropdown_menu = { opacity = 0.8; }
};

@eadwu eadwu mentioned this pull request Jun 2, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants