Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Set-up automatic closing of stale issues (or something similar) - there are too many open issues that date back from 4 years ago #804

Open
kwand opened this issue Mar 23, 2022 · 7 comments

Comments

@kwand
Copy link

kwand commented Mar 23, 2022

I've been meaning to comment on this a few years ago, but I think it's appropriate to say something about it now - given that there are still pages of open issues dating back from 2019, 2018 (some of which I know for a fact are outdated or have been addressed).

Now, I recognize the response time to latest issues have not been the best lately (given there are still tons of issues from the last 6 months with no replies yet), so perhaps the staleness "countdown" can be set rather high. Of course, issues can always be re-opened if they were wrongly automatically closed.

But I fail to see why many issues dating from beyond the last two years should be kept open - given that many of the ones I've examined seem to no longer apply on the latest branch.

(I would not mind helping to provide a list that should be closed manually - but I believe adding automatic closing is worthwhile)

@yshui
Copy link
Owner

yshui commented Mar 30, 2022

Hi, i would appreciate it if you can point out some outdated issues, thanks. As for auto-closing, for personal experiences I don't like doing that.

@kwand
Copy link
Author

kwand commented May 31, 2022

@yshui Apologies for the late reply - been quite busy and forgot that I even opened this.

I can provide you with a list of issues that I believe should most definitely be revisited and seriously considered for closure from the last and second pages (i.e. page 9/10 as it is today; not sure when you will see this).

Hopefully, you'll agree with me that there are more than a handful open issues that should no longer remain open among the 236 that exist today. I can confirm that it is not just pages 9/10 that have these kinds of open issues - I went through more pages than 9/10 prior to opening this issue, but unfortunately, I no longer remember the exact issues from the other pages + currently do not have the time to go through more.

While I do prefer manual inspection to an automated system, in the absence of someone dedicated to going through these older issues and closing them, an automated system I believe is not a bad option to consider - especially when one can customize how strict/relaxed the system could be.

@tryone144
Copy link
Collaborator

Thanks for looking into some of these ancient issues. I've closed some that are (almost) certainly no longer relevant.

However, I am not too sure on how to handle the "performance" issues. These seem to be hard to reproduce and are most likely no longer relevant given the huge changes in the backends over the last years.

We could tag these issues as stale and close them after some (negotiable) time has passed.

I think the biggest problem as of now is that there are multiple issues that are most likely duplicates — or at least very similar — but cannot be easily found via the search. This is in part caused by the inclusion of the complete (sample) config in each issue, which makes searching for a specific option impossible.

@masaeedu
Copy link

masaeedu commented Feb 28, 2023

@kwand I think these issues should go through at least the "is it still stale" -> "no response within x duration" -> "close" workflow. At least one of the issues you've selected in your list still affects me today (#200)

@yshui
Copy link
Owner

yshui commented Feb 7, 2024

@masaeedu unfortunately #200 is a design decision on chromium's side, so there's nothing picom can do. i suggest you report an issue to them.

@yshui
Copy link
Owner

yshui commented Feb 7, 2024

ok i've been procrastinating long enough, let's close some of these issues.

@kwand thanks again for find them.

as for auto-closing, if there is a bot poking me every couple months asking me to write some nonsensical replies to keep an issue alive, i'd be pretty annoyed. that's why i don't like doing it.

@yshui
Copy link
Owner

yshui commented Feb 7, 2024

So I thought about this. Although I don't think we should do auto-closing in general, there is still some automation we can do:

  1. auto label stale issues, making them easy to find. and then we can periodically go through them and decide whether to close them. scrap this one, you can search for issues like this on github easily: is:issue is:open updated:<2020-01-01
  2. delayed close. for example after an issue is fixed and waiting for user confirmation, i should be able to mark the issue for delayed close if the reporter doesn't respond for a long time.

Does anyone know if there is tooling that can do these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants