-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clip-shadow-above
configuration and wintype option
#656
Conversation
Codecov Report
@@ Coverage Diff @@
## next #656 +/- ##
==========================================
- Coverage 39.33% 39.23% -0.11%
==========================================
Files 46 46
Lines 9581 9612 +31
==========================================
+ Hits 3769 3771 +2
- Misses 5812 5841 +29
|
Thanks for implementing this! As for the name, I am not sure either. I am thinking about something like |
After giving this some more thought, I think Apart from the name change, I am probably going to rebase this on top of the changes in #657. |
@tryone144 Yeah, that sounds good 👍 |
Added the new `clip-shadow-above` configuration and wintype option. These allow the user to select windows to clip from the shadow region of other windows, i.e. don't paint shadows on top of them. This should provide a more useful and userfriendly alternative to the deprecated `shadow-exclude-reg` option — especially for docks and bars.
14962eb
to
4b5cc05
Compare
shadow-crop-window
configuration and crop-shadow
wintype optionsclip-shadow-above
configuration and wintype option
Thank you! |
Any possibility to clip shadow above shadow and thus avoid overlapping shadows? |
Added the new
shadow-crop-window
configuration option andcrop-shadow
wintype option. These allow the user to select windows to crop from the shadow region of other windows, i.e. don't paint shadows on top of them.This should provide a more useful and user friendly alternative to the deprecated
shadow-exclude-reg
option.See #494 and #582 (comment).
The name of this new option is up for debate. My rationale behind not calling it
shadow-exclude-window
was to avoid confusion with the similarly namedshadow-exclude
option that disables the shadow that a window casts. In contrast, the new option prevents shadows from being cast onto the target window.I am not a native speaker, so if crop does not intuitively convey they right meaning, clip might work as well (or trim, truncate, …).
EDIT: Renamed the options to
clip-shadow-above
.