backend: xrender: force 32bit ARGB visual when adding rounded corners #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1003 +/- ##
==========================================
- Coverage 37.56% 37.55% -0.02%
==========================================
Files 49 49
Lines 11193 11197 +4
==========================================
Hits 4205 4205
- Misses 6988 6992 +4
|
|
nice, thank you! looks good, builds and works for me. i was thinking about this way of fixing the original issue but i was still hoping that there is a way to gracefully share the logic with the |
Force the temporary picture to a 32-bit ARGB visual when masking it for rounded corners to keep the transparency information. Otherwise, windows with a 24-bit visual would get black corners instead. Authored-by: Bernd Busse <bernd@busse-net.de> Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
yshui
force-pushed
the
fix/xrender-black-corners
branch
from
6406883
to
fd9c52d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force the temporary picture to a 32-bit ARGB visual when masking it for rounded corners to keep the transparency information. Otherwise, windows with a 24-bit visual would get black corners instead.
Related: #997