Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: handle max-brightness option better #1007

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

absolutelynothelix
Copy link
Collaborator

@absolutelynothelix absolutelynothelix commented Jan 24, 2023

allow use of the max-brightness option with the egl backend, report it's unavailability better and unify the window-shader-fg and window-shader-fg-rule options unavailability reporting with it

@absolutelynothelix
Copy link
Collaborator Author

absolutelynothelix commented Jan 24, 2023

code:cow: is silent today

@absolutelynothelix absolutelynothelix changed the title options: allow use of the max-brightness option for the egl backend options: handle max-brightness option better Jun 16, 2023
allow it's use with the egl backend and report it's unavailability
better
unify unavailability reporting of the max-brightness, window-shader-fg
and window-shader-fg-rule options
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1007 (9f9cff3) into next (5e22434) will increase coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1007      +/-   ##
==========================================
+ Coverage   37.51%   37.66%   +0.14%     
==========================================
  Files          49       49              
  Lines       11171    11171              
==========================================
+ Hits         4191     4207      +16     
+ Misses       6980     6964      -16     
Impacted Files Coverage Δ
src/options.c 18.96% <0.00%> (ø)

... and 2 files with indirect coverage changes

@yshui yshui merged commit e2ecef9 into yshui:next Jun 16, 2023
6 checks passed
@absolutelynothelix absolutelynothelix deleted the egl-allow-max-brightness branch June 16, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants