Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: fix resize factor calculation #1095

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

absolutelynothelix
Copy link
Collaborator

@absolutelynothelix absolutelynothelix commented Jul 5, 2023

the corresponding regions need to be resized once for each window in the stack above the damaged window including the damaged window itself. we were off by one.

fixes #1088

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1095 (e8477e0) into next (4a39423) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1095      +/-   ##
==========================================
- Coverage   37.56%   37.38%   -0.18%     
==========================================
  Files          49       49              
  Lines       11190    11190              
==========================================
- Hits         4203     4183      -20     
- Misses       6987     7007      +20     
Impacted Files Coverage Δ
src/backend/backend.c 60.91% <100.00%> (ø)

... and 3 files with indirect coverage changes

src/backend/backend.c Outdated Show resolved Hide resolved
the corresponding regions need to be resized once for each window in the
stack above the damaged window including the damaged window itself. we
were off by one.
@absolutelynothelix absolutelynothelix changed the title backend: make sure that the resize factor is at least 1 backend: fix resize factor calculation Jul 6, 2023
@yshui
Copy link
Owner

yshui commented Jul 6, 2023

thanks. i'll make a note that we need to look at damage resizing again in the future. the region that needs to be repaint for blur is different for each level in the stack, but right now we are using the same one for all windows.

@yshui yshui merged commit 961dc99 into yshui:next Jul 6, 2023
6 checks passed
@absolutelynothelix absolutelynothelix deleted the resize-factor branch July 6, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual artifacts when using blur and urxvt terminal
2 participants