Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: drop kawase blur method #1102

Merged
merged 2 commits into from
Sep 10, 2023
Merged

config: drop kawase blur method #1102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c83fb8
config: drop kawase blur method
absolutelynothelix Jul 21, 2023
4a8b937
config: refactor the parse_blur_method function
absolutelynothelix Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions src/config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,20 +183,19 @@
}

enum blur_method parse_blur_method(const char *src) {
if (strcmp(src, "kernel") == 0) {
return BLUR_METHOD_KERNEL;
} else if (strcmp(src, "box") == 0) {
if (strcmp(src, "box") == 0) {

Check warning on line 186 in src/config.c

View check run for this annotation

Codecov / codecov/patch

src/config.c#L186 

Added line #L186 was not covered by tests
return BLUR_METHOD_BOX;
} else if (strcmp(src, "gaussian") == 0) {
return BLUR_METHOD_GAUSSIAN;
} else if (strcmp(src, "dual_kawase") == 0) {
return BLUR_METHOD_DUAL_KAWASE;
} else if (strcmp(src, "kawase") == 0) {
log_warn("Blur method 'kawase' has been renamed to 'dual_kawase'. "
"Interpreted as 'dual_kawase', but this will stop working "
"soon.");
}
if (strcmp(src, "dual_kawase") == 0) {

Check warning on line 189 in src/config.c

View check run for this annotation

Codecov / codecov/patch

src/config.c#L189 

Added line #L189 was not covered by tests
return BLUR_METHOD_DUAL_KAWASE;
} else if (strcmp(src, "none") == 0) {
}
if (strcmp(src, "gaussian") == 0) {
return BLUR_METHOD_GAUSSIAN;

Check warning on line 193 in src/config.c

View check run for this annotation

Codecov / codecov/patch

src/config.c#L192-L193 

Added lines #L192 - L193 were not covered by tests
}
if (strcmp(src, "kernel") == 0) {
return BLUR_METHOD_KERNEL;

Check warning on line 196 in src/config.c

View check run for this annotation

Codecov / codecov/patch

src/config.c#L195-L196 

Added lines #L195 - L196 were not covered by tests
}
if (strcmp(src, "none") == 0) {

Check warning on line 198 in src/config.c

View check run for this annotation

Codecov / codecov/patch

src/config.c#L198 

Added line #L198 was not covered by tests
return BLUR_METHOD_NONE;
}
return BLUR_METHOD_INVALID;
Expand Down