Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated options for v11 #1162

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Remove deprecated options for v11 #1162

merged 4 commits into from
Jan 15, 2024

Conversation

yshui
Copy link
Owner

@yshui yshui commented Jan 14, 2024

No description provided.

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (eb3a58a) 36.67% compared to head (30e37db) 36.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1162      +/-   ##
==========================================
- Coverage   36.67%   36.52%   -0.15%     
==========================================
  Files          50       50              
  Lines       11495    11498       +3     
==========================================
- Hits         4216     4200      -16     
- Misses       7279     7298      +19     
Files Coverage Δ
src/config_libconfig.c 57.32% <0.00%> (-0.19%) ⬇️
src/options.c 18.88% <0.00%> (-0.09%) ⬇️

... and 2 files with indirect coverage changes

Deprecated in compton, in distant history.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Deprecated in v6, we forgot to remove it.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Deprecated in v8.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Copy link
Collaborator

@absolutelynothelix absolutelynothelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yshui yshui merged commit a73ca2d into next Jan 15, 2024
16 checks passed
@yshui yshui deleted the deprecations-11 branch January 15, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants