backend: gl: inherit image's inner properties in the gl_image_decouple function #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #1179 +/- ##
==========================================
- Coverage 36.43% 36.41% -0.02%
==========================================
Files 50 50
Lines 11533 11541 +8
==========================================
+ Hits 4202 4203 +1
- Misses 7331 7338 +7
|
|
@absolutelynothelix you are right about |
…e function Image decouple should keep all the image properies from the source image, so shader must be copied. And there are also some internal properties what should be inherited but wasn't. In particular this prevents images from losing their shaders when alpha is applied. Fixes yshui#1174
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
yshui
force-pushed
the
inherit-shader-on-decouple
branch
from
073acd4
to
c738400
Compare
absolutelynothelix
changed the title
|
if anyone gets confused by this pull request in the future: initially it was only about inheriting an image's shader in the |
yshui
force-pushed
the
inherit-shader-on-decouple
branch
from
f0807dc
to
7b295b8
Compare
Present shader optionally does dithering, but that's not needed for decoupling. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
yshui
force-pushed
the
inherit-shader-on-decouple
branch
from
7b295b8
to
9204426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1174.
also i'm a bit worried that
has_alpha,y_invertedandauxiliary_textureare not inherited but i'm not sure if it causes any issues now or could cause any issues in the future.backend: gl: inherit image's shader in the gl_image_decouple function
this prevents images from losing their shaders when alpha is applied