cache GLX fbconfigs #1190
Merged
cache GLX fbconfigs #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #1190 +/- ##
==========================================
- Coverage 36.29% 36.25% -0.04%
==========================================
Files 50 50
Lines 11488 11495 +7
==========================================
- Hits 4169 4167 -2
- Misses 7319 7328 +9
|
yshui
force-pushed
the
cache-fbconfig
branch
3 times, most recently
from
3dcde2d
to
b940fb4
Compare
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
It's fairly small, so it's reasonable to put it on the stack. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
This should marginally speed up pixmap binding for the glx backend (we don't need FBConfigs for egl). Fix a long running complaint in #381 (unrelated issue, but there is complaint in there about glXChooseFBConfig being called whenever we bind a new pixmap). Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
yshui
force-pushed
the
cache-fbconfig
branch
from
b940fb4
to
85bb56e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.