Animatation part I: fading is animation #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1220 +/- ##
==========================================
+ Coverage 36.55% 36.84% +0.28%
==========================================
Files 51 52 +1
Lines 11948 12016 +68
==========================================
+ Hits 4368 4427 +59
- Misses 7580 7589 +9
|
yshui
force-pushed
the
generic-fading
branch
14 times, most recently
from
297cbc4
to
9a29e46
Compare
This should replace the current fading animation implementation. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Fading behavior is changed slightly when a window's opacity is changed while the window is already fading in/out. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Now the logic for handling unmapping-then-mapping-at-a-new-position is all in the same function instead of being split into map_win_start and win_process_update_flags. Hopefully this is slightly easier to understand. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Remove transitional window states, such as UNMAPPING, MAPPING, etc. We are trying to generialize animation, keeping all those states for animation/fading will only make things more complicated. Instead the window state now exactly reflect how the window is to the X server, and we check the animatable states to determine the animation progress. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.