Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: remove some really old options #1254

Merged
merged 2 commits into from
May 12, 2024
Merged

config: remove some really old options #1254

merged 2 commits into from
May 12, 2024

Conversation

yshui
Copy link
Owner

@yshui yshui commented May 12, 2024

Deprecated in v2, and we added a better alternative to it.

Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 40.72%. Comparing base (70c4327) to head (f2ce275).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1254      +/-   ##
==========================================
+ Coverage   40.59%   40.72%   +0.12%     
==========================================
  Files          59       59              
  Lines       12549    12465      -84     
==========================================
- Hits         5094     5076      -18     
+ Misses       7455     7389      -66     
Files Coverage Δ
src/common.h 44.82% <ø> (ø)
src/config.c 57.75% <ø> (+8.13%) ⬆️
src/config.h 23.52% <ø> (ø)
src/picom.c 61.63% <ø> (-0.14%) ⬇️
src/render.c 0.58% <ø> (+<0.01%) ⬆️
src/renderer/command_builder.c 80.07% <100.00%> (-0.24%) ⬇️
src/renderer/renderer.c 63.66% <ø> (ø)
src/config_libconfig.c 58.58% <0.00%> (-0.20%) ⬇️
src/options.c 24.94% <0.00%> (+0.21%) ⬆️

... and 3 files with indirect coverage changes

@yshui yshui marked this pull request as ready for review May 12, 2024 12:51
Deprecated in v2, and we added a better alternative to it.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
These are removed long before our time, I don't even know what they are.
We have been rejecting them with an error message for a while too, it's
time to just remove them.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@yshui yshui changed the title config: remove --shadow-exclude-reg config: remove some really old options May 12, 2024
@yshui yshui merged commit 4bb0a71 into next May 12, 2024
18 checks passed
@yshui yshui deleted the shadow-exclude-reg branch May 12, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant