Invert script optimizations #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary if statement and unnecessary /dev/null redirect on line 19 Line 26 can use argless printf rather than echo -n Error verbose prints in red and to STDERR rather than to STDOUT Textually replaced compton with picom where applicable. Removed unnecessary semicolons after exit commands I might've missed/screwed something but lets hope that isnt the case 😎
Missed a textual remnant of compton, whoops
Missed a few more comptons in comments
Codecov Report
@@ Coverage Diff @@
## next #362 +/- ##
==========================================
+ Coverage 32.39% 32.40% +0.01%
==========================================
Files 46 46
Lines 8523 8523
==========================================
+ Hits 2761 2762 +1
+ Misses 5762 5761 -1
|
Error verbose for lack of X Display variable now uses stderr function
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
I could've/likely missed a few things, however the script still seems runs the same for me.