Rounded corner cleanup

[yshui]

No description provided.

[yshui]

ping #361 and #229

[jslick]

Hi, is this branch a WIP? I'm having trouble building it.

[16/30] Compiling C object src/picom.p/backend_backend.c.o
FAILED: src/picom.p/backend_backend.c.o
cc -Isrc/picom.p -Isrc -I../src -Isubprojects/test.h -I../subprojects/test.h -I/usr/include/pixman-1 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c11 -O3 '-DCOMPTON_VERSION="vgit-2c696"' -DNDEBUG -D_GNU_SOURCE -DHAS_STDC_PREDEF_H -Wall -Wcast-function-type -Wignored-qualifiers -Wmissing-parameter-type -Wnonnull -Wshadow -Wno-type-limits -Wold-style-declaration -Woverride-init -Wsign-compare -Wtype-limits -Wuninitialized -Wshift-negative-value -Wunused-but-set-parameter -Wunused-parameter -Wimplicit-fallthrough -Wno-missing-braces -Wconversion -Wempty-body -march=x86-64 -mtune=generic -O2 -fno-plt -D_FORTIFY_SOURCE=2 -DCONFIG_LIBCONFIG -DCONFIG_REGEX_PCRE -DCONFIG_REGEX_PCRE_JIT -DCONFIG_OPENGL -DGL_GLEXT_PROTOTYPES -DCONFIG_DBUS -DHAS_INOTIFY -MD -MQ src/picom.p/backend_backend.c.o -MF src/picom.p/backend_backend.c.o.d -o src/picom.p/backend_backend.c.o -c ../src/backend/backend.c
../src/backend/backend.c: In function ‘paint_all_new’:
../src/backend/backend.c:152:57: warning: passing argument 3 of ‘ps->backend_data->ops->compose’ makes integer from pointer without a cast [-Wint-conversion]
  152 |   ps->backend_data->ops->compose(ps->backend_data, t, ps->root_image, 0, 0,
      |                                                       ~~^~~~~~~~~~~~
      |                                                         |
      |                                                         void *
../src/backend/backend.c:152:57: note: expected ‘int’ but argument is of type ‘void *’
../src/backend/backend.c:152:3: error: too many arguments to function ‘ps->backend_data->ops->compose’
  152 |   ps->backend_data->ops->compose(ps->backend_data, t, ps->root_image, 0, 0,
      |   ^~

[tryone144]

Hi, is this branch a WIP? I'm having trouble building it.

Yup, see #493 (comment):

Thanks for your contribution. The round branch is still WIP so it's not expected to compile.

[subnut]

@yshui Any ETA to get it done?
I mean, ibhagwan's fork is working fine, isn't it? So why not here?

[codecov]

Codecov Report

Merging #480 (585e406) into next (a335eed) will decrease coverage by 0.27%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             next     #480      +/-   ##
==========================================
- Coverage   37.51%   37.23%   -0.28%     
==========================================
  Files          46       46              
  Lines        9432     9456      +24     
==========================================
- Hits         3538     3521      -17     
- Misses       5894     5935      +41     

Impacted Files	Coverage Δ
src/opengl.c	0.00% <0.00%> (ø)
src/opengl.h	60.46% <ø> (ø)
src/win.c	68.07% <0.00%> (-0.98%)	⬇️
src/win.h	78.12% <ø> (ø)
src/picom.c	67.54% <0.00%> (-0.64%)	⬇️
src/backend/dummy/dummy.c	80.32% <0.00%> (-0.32%)	⬇️

[RandomExplosion]

@yshui what's the current status on this PR?

[tryone144]

This PR has been closed in favour of #551, #558, and #614 for the legacy backends. Rounded corners should already work there.
The implementation of rounded corners for the experimental-backends is tracked in #658 (currently WIP).