fix --write-pid-path is no effective #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #492 +/- ##
==========================================
- Coverage 36.85% 36.84% -0.02%
==========================================
Files 45 45
Lines 8907 8918 +11
==========================================
+ Hits 3283 3286 +3
- Misses 5624 5632 +8
|
yshui
reviewed
Sep 16, 2020
|
@jialeens Thanks for the PR!. You also need to handle this option coming from command line. |
|
@yshui |
yshui
reviewed
Sep 16, 2020
src/options.c
Outdated
| @@ -700,6 +700,11 @@ bool get_cfg(options_t *opt, int argc, char *const *argv, bool shadow_enable, | |||
| case 322: | |||
| // --logpath, --log-file | |||
| free(opt->logpath); | |||
| if (*optarg != '/') { | |||
| log_error("The --log-file in your configuration file is not" | |||
There was a problem hiding this comment.
there is no requirement for --log-file to be an absolute path.
|
Sorry, closed by mistake |
|
Pushed your changes to |
|
OK, I see it. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix --write-pid-path is no effective
the --write-pid-path is no effective，When picom is started, the configuration --write-pid-path is not read.
When picom exiting, remove the pid file.