New backend rounded corner, part 1 #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
xcb_render_triangle is slow because (at least for Glamor) it's rasterizing the triangles on CPU. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Codecov Report
@@ Coverage Diff @@
## next #716 +/- ##
==========================================
- Coverage 39.31% 39.28% -0.03%
==========================================
Files 46 46
Lines 9584 9644 +60
==========================================
+ Hits 3768 3789 +21
- Misses 5816 5855 +39
|
|
@tryone144 Hi, does this look reasonable to you? I want to bring the new backends to feature parity quickly (instead of a complete implementation) in terms of rounded corners, and make a new release. That's why I made a new PR alongside #658 After this PR, I would implement rounded border for glx. |
I'll try to find some time over the weekend to take a look at this. |
tryone144
approved these changes
Nov 7, 2021
Thanks, @tryone144 Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
yshui
force-pushed
the
new-backend-rounded-corner-1
branch
from
da909b7
to
8eb5bb0
Compare
|
@tryone144 thanks for the review! looks like this is good to be merged. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add basic rounded corner for the new glx and xrender backends.