-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transparent-clipping-exclude config option to improve usability with screenshooting tools #738
Conversation
Codecov Report
@@ Coverage Diff @@
## next #738 +/- ##
==========================================
+ Coverage 37.97% 37.98% +0.01%
==========================================
Files 48 48
Lines 10562 10564 +2
==========================================
+ Hits 4011 4013 +2
Misses 6551 6551
|
What is the plan with this? This is exactly what I need. I have seen this "work-around" #663 . But it does not help me because i want the rounded edges of my "d-menu" to be transparent to other windows. |
I'm happy to help get this merged if there's interest. I've been using this branch daily for the past few months and it works well for me. cc @yshui |
@stefanradziuk hi! sorry for neglecting this PR for so long! so |
No worries, thanks for the suggestion. Cached the |
@stefanradziuk this looks good to me! can you update the help messages in thanks! |
7bd63db
to
e0bf4f6
Compare
…ed region Transparent clipping interacts poorly with programs whose transparent interface elements must show windows below them for functionality, for example screenshot utilities.
e0bf4f6
to
2328b97
Compare
Done, let me know if the help entry makes sense. Also, I wasn't sure about the switch case numbering in |
Yep, it looks good! Thank you! |
As described in #663, using
transparent-clipping
does not interact well with screenshooting tools with window selection indicators. The screenshooting tool draws a mostly transparent full-screen window to highlight the window selection, which means that withtransparent-clipping
enabled only the root window and the window selection indicator are visible.This PR adds an
transparent-clipping-exclude
config entry, which allows the user to specify windows that should bypass thetransparent-clipping = true
setting. The transparent elements of such windows will show any windows below, not just the root window.Tested with
slop
,xfce4-screenshooter
andst
(I don't see much point in using this with a terminal emulator window but it works).