Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding transition (cleanup) #766

Closed
wants to merge 4 commits into from
Closed

Adding transition (cleanup) #766

wants to merge 4 commits into from

Conversation

Arian8j2
Copy link

Cleanup of #752 with changes that requested.

@Arian8j2 Arian8j2 mentioned this pull request Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #766 (dddf8a0) into next (3b9af14) will decrease coverage by 0.46%.
The diff coverage is 22.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #766      +/-   ##
==========================================
- Coverage   39.41%   38.95%   -0.47%     
==========================================
  Files          46       47       +1     
  Lines        9557     9729     +172     
==========================================
+ Hits         3767     3790      +23     
- Misses       5790     5939     +149     
Impacted Files Coverage Δ
src/config.c 42.74% <ø> (ø)
src/config.h 23.52% <ø> (ø)
src/timing_functions.c 0.00% <0.00%> (ø)
src/win.h 78.12% <ø> (ø)
src/picom.c 69.53% <8.69%> (-1.99%) ⬇️
src/event.c 69.12% <58.33%> (-0.37%) ⬇️
src/config_libconfig.c 59.35% <61.90%> (+0.32%) ⬆️
src/win.c 68.18% <80.00%> (-0.79%) ⬇️

Arian8j2 referenced this pull request Jan 28, 2022
It's meaningless without the sw-opti option, which has been deprecated
since v6.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
src/picom.c Outdated Show resolved Hide resolved
Copy link
Owner

@yshui yshui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides some style problems.

Will merge after v9 is out the door

src/picom.c Show resolved Hide resolved
src/picom.c Outdated Show resolved Hide resolved
src/config.c Outdated Show resolved Hide resolved
@Arian8j2
Copy link
Author

Arian8j2 commented Feb 1, 2022

All style problems have been fixed.

@n-ovux n-ovux mentioned this pull request Apr 16, 2022
@c02y
Copy link

c02y commented May 6, 2022

Any problem? Is it going to be merged and released any time soon?

@Arian8j2
Copy link
Author

Arian8j2 commented May 6, 2022

@c02y This pr gonna merge with #772, Wait for that to get ready.

@beyond9thousand
Copy link

@Arian8j2 any idea when this is going to happen?

@Arian8j2
Copy link
Author

Arian8j2 commented Jul 5, 2022

@beyond9thousand no idea

@beyond9thousand
Copy link

beyond9thousand commented Jul 6, 2022

sad, been eagerly waiting to use a stable animation fork. both dc and pijulius give weird graphical artefacts that have taken me ages to work around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants