Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation chore #768

Merged
merged 14 commits into from
Jan 27, 2022
Merged

Deprecation chore #768

merged 14 commits into from
Jan 27, 2022

Conversation

yshui
Copy link
Owner

@yshui yshui commented Jan 24, 2022

Preparing for v9 release.

It was deprecated in v6, but wasn't formally deprecated back then (e.g.
no warnings were printed for it). So formally deprecate it here.

This also left the refresh-rate option unused, so that will be
deprecated too.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Deprecated since v6.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Deprecated since v6.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Deprecated since v6.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Deprecated since v4.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Deprecated since v5.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Deprecated since v5.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Deprecated since v5.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Deprecated in v5.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@yshui yshui requested a review from tryone144 January 24, 2022 18:27
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #768 (b65c8c7) into next (43f3560) will increase coverage by 0.04%.
The diff coverage is 18.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #768      +/-   ##
==========================================
+ Coverage   39.29%   39.34%   +0.04%     
==========================================
  Files          46       46              
  Lines        9639     9550      -89     
==========================================
- Hits         3788     3757      -31     
+ Misses       5851     5793      -58     
Impacted Files Coverage Δ
src/common.h 78.26% <ø> (+11.59%) ⬆️
src/config.c 42.74% <ø> (ø)
src/config.h 23.52% <ø> (ø)
src/dbus.c 27.27% <0.00%> (ø)
src/options.c 21.56% <0.00%> (+0.09%) ⬆️
src/picom.h 66.66% <ø> (ø)
src/config_libconfig.c 59.03% <26.66%> (+0.55%) ⬆️
src/picom.c 70.99% <75.00%> (+2.61%) ⬆️
src/utils.h 33.33% <0.00%> (-16.67%) ⬇️
src/win.c 68.13% <0.00%> (-0.85%) ⬇️
... and 3 more

It's meaningless without the sw-opti option, which has been deprecated
since v6.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Deprecated since v4.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
It was deprecated in v4, but warning message wasn't printed for
specifying it on the command line.

Properly deprecate it now.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
This is deprecated since v5, but we forgot to change this to error in
v8.

Doing it now.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@yshui yshui merged commit 0ad6685 into next Jan 27, 2022
@yshui yshui deleted the deprecation-chore branch January 27, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants