Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined symbol: glEGLImageTargetTexStorageEXT #930

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

omar-polo
Copy link
Contributor

Hello,

picom fails to build on OpenBSD due to a linker error:

ld: error: undefined symbol: glEGLImageTargetTexStorageEXT
>>> referenced by egl.c:273 (../src/backend/gl/egl.c:273)
>>>               src/picom.p/backend_gl_egl.c.o:(egl_bind_pixmap)

The compiler doesn't report any warning while compiling, but the linking faills. There's a prototype for glEGLImageTargetTexStorageEXT, but I guess the function pointer needs to be retrieved via eglGetProcAddress? I'm not sure. I don't have any prior experience with opengl, mesa or X11 rendering in general, so please review this diff with extra care.

I've come up with this diff that at least allows to build and seems to work. I'm running picom --config /dev/null --vsync --backend egl.

Note that it's lacking a cast on the return of eglGetProcAddress, and I'm not sure I'm using eglGetProcAddress in an idiomatic way.

Thanks!

@yshui yshui marked this pull request as ready for review November 22, 2022 15:07
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #930 (2d35f78) into next (ec02fc6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #930      +/-   ##
==========================================
- Coverage   37.74%   37.72%   -0.02%     
==========================================
  Files          48       48              
  Lines       10656    10661       +5     
==========================================
  Hits         4022     4022              
- Misses       6634     6639       +5     
Impacted Files Coverage Δ
src/backend/gl/egl.c 24.88% <0.00%> (-0.59%) ⬇️

@yshui yshui merged commit 6bcda50 into yshui:next Nov 22, 2022
@omar-polo
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants