Consider borders when creating the mask image #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With rounded corners, X11 native border and blur enabled, left and bottom 2*border_width pixels were not blurred, since mask did not include border_width, only content width and height. Create mask image with dimensions that include border width. Signed-off-by: Evgeniy Baskov <j-basevgser@yandex.ru>
Codecov Report
@@ Coverage Diff @@
## next #950 +/- ##
=======================================
Coverage 37.59% 37.59%
=======================================
Files 48 48
Lines 10667 10667
=======================================
Hits 4010 4010
Misses 6657 6657
|
|
Good catch 😅 Thank you! |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Dec 22, 2022
https://build.opensuse.org/request/show/1044090 by user mia + dimstar_suse - Update to version 10.2 Fixes: * Window border not being considered when calculating its mask gh#yshui/picom#950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With rounded corners, X11 native border and blur enabled,
left and bottom 2*border_width pixels were not blurred,
since mask did not include border_width, only content width and height.
Create mask image with dimensions that include border width.
I hope the fix is correct, since I am not that familiar with the codebase.
At least for me it works fine for all of the new backends.
An image, demonstrating the issue with overly large borders and corner radius:
