xrender: fix leak in deinit

[absolutelynothelix]

fixes at least #960

i'm on fire today 😎

vibin.mp4

[codecov]

Codecov Report

Merging #979 (dd9ffec) into next (48d3a0b) will increase coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             next     #979      +/-   ##
==========================================
+ Coverage   37.68%   37.82%   +0.14%     
==========================================
  Files          48       48              
  Lines       10847    10849       +2     
==========================================
+ Hits         4088     4104      +16     
+ Misses       6759     6745      -14     

Impacted Files	Coverage Δ
src/backend/xrender/xrender.c	0.00% <0.00%> (ø)
src/picom.c	65.93% <0.00%> (+0.59%)	⬆️
src/win.c	68.25% <0.00%> (+0.80%)	⬆️

[yshui]

🔥

[yshui]

can you also add a if (xd->back[i] != XCB_NONE) for me?

[absolutelynothelix]

can you also add a if (xd->back[i] != XCB_NONE) for me?

looking at the backend_xrender_init i believe it should look like this?

        for (int i = 0; i < 3; i++) {
                if (xd->back[i] != XCB_NONE) {
                        xcb_render_free_picture(xd->base.c, xd->back[i]);
                }
                if (xd->back_pixmap[i] != XCB_NONE) {
                        xcb_free_pixmap(xd->base.c, xd->back_pixmap[i]);
                }
        }

[yshui]

yep!

[absolutelynothelix]

ah, give me a second to figure out how do i commit it properly

[absolutelynothelix]

done

[yshui]

thank you!