Fix sequence additions (#105) #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gth828r
reviewed
Oct 31, 2023
gth828r
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
I ran the tests and verified that the new one passes for me. I made a comment about some code comments that could be removed, but otherwise I think this is OK. I don't have enough background on the generator, parser, or resolver to provide a full code review in a timely fashion.
gabhijit
commented
Nov 1, 2023
Sequences Additions (those after `...` Extension Marker) were treated as components from the root components. This resulted in structures with components being treated as root components and caused errors in codecs (due to incorrect number of components determined). Fixed in the parser and resolver. Also defined a new `enum` type to deal with the fact that the sequence additions can be addition groups or components (stand alone).
Initially we were simply parsing E2SM specificiation, Now also added codec example with codec round-trip.
When we were encoding a value of '0' for a constrained whole number, the required length determinent was not getting the proper value. Fixed this to get the issue.
gabhijit
force-pushed
the
fix-sequence-additions
branch
from
09a1801 to
280baf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.