Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error handling with match #119

Merged
merged 1 commit into from
May 29, 2024

Conversation

Its-Just-Nans
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans commented May 29, 2024

Help with #116

@Its-Just-Nans Its-Just-Nans force-pushed the handle-error-constraints branch from 7e4b321 to 67b5c2c Compare May 29, 2024 08:51
Copy link
Collaborator

@gabhijit gabhijit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test case for this change in resolver? Or if you think this is captured in any of the issues you have raised, simply adding reference to that issue in the commit message should be good enough!

Signed-off-by: n4n5 <its.just.n4n5@gmail.com>
@Its-Just-Nans Its-Just-Nans force-pushed the handle-error-constraints branch from 67b5c2c to 74f36a8 Compare May 29, 2024 08:59
@Its-Just-Nans
Copy link
Contributor Author

Its-Just-Nans commented May 29, 2024

Done!

I'm not sure if this will happen again but I know that this code helped me during debugging of #116

@gabhijit gabhijit merged commit e536648 into ystero-dev:master May 29, 2024
3 checks passed
@Its-Just-Nans Its-Just-Nans deleted the handle-error-constraints branch May 29, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants