Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align data to 8-bit boundry when decoding for OPEN type #127

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Align data to 8-bit boundry when decoding for OPEN type #127

merged 2 commits into from
Sep 21, 2024

Conversation

KiOui
Copy link
Contributor

@KiOui KiOui commented Sep 20, 2024

Closes #126

This PR adds a call to decode_align before returning when decoding the OPEN data type.

Signed-off-by: Lars van Rhijn <larsvanrhijn@gmail.com>
@KiOui
Copy link
Contributor Author

KiOui commented Sep 20, 2024

If there is anything that still needs to be done (e.g. adding a test case that verifies this), please don't hesitate to ask 😄

@gabhijit
Copy link
Collaborator

If there is anything that still needs to be done (e.g. adding a test case that verifies this), please don't hesitate to ask 😄

Hi @KiOui : Thanks for the PR. The code looks simple enough! Will it be possible to add a test case for this particular case? Most likely why this was missed was so far Open type was the only (or last) type while decoding so it didn't matter.

Having a test case for this would help a lot.

…on type

Signed-off-by: Lars van Rhijn <lars@radix-security.com>
@KiOui
Copy link
Contributor Author

KiOui commented Sep 21, 2024

If there is anything that still needs to be done (e.g. adding a test case that verifies this), please don't hesitate to ask 😄

Hi @KiOui : Thanks for the PR. The code looks simple enough! Will it be possible to add a test case for this particular case? Most likely why this was missed was so far Open type was the only (or last) type while decoding so it didn't matter.

Having a test case for this would help a lot.

I have now added a test case. I was not completely sure where to put it so if it's in the wrong place please indicate!

@gabhijit
Copy link
Collaborator

If there is anything that still needs to be done (e.g. adding a test case that verifies this), please don't hesitate to ask 😄

Hi @KiOui : Thanks for the PR. The code looks simple enough! Will it be possible to add a test case for this particular case? Most likely why this was missed was so far Open type was the only (or last) type while decoding so it didn't matter.
Having a test case for this would help a lot.

I have now added a test case. I was not completely sure where to put it so if it's in the wrong place please indicate!

This is perfect! Thank you for the PR. I believe once the Run is successful, we can merge it.

Copy link
Collaborator

@gabhijit gabhijit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@gabhijit gabhijit merged commit 93e09cc into ystero-dev:master Sep 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing decode alignment for ASN open types
2 participants