[ie/youtube] Remove n function extraction fallback
#10396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes yt-dlp#10391 Authored by: pukkandan, seproDev Co-Authored-By: pukkandan <pukkandan.ytdlp@gmail.com>
|
Makes you wonder why we kept the redundant extraction, and in that order ... |
11 tasks
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 10, 2024
* improve extraction of function name (like yt-dlp/yt-dlp#10390) * always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan)
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 10, 2024
* improve extraction of function name (like yt-dlp/yt-dlp#10390) * always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan)
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 10, 2024
* improve extraction of function name (like yt-dlp/yt-dlp#10390) * always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan)
dirkf
added a commit
to ytdl-org/youtube-dl
that referenced
this pull request
Jul 10, 2024
* improve extraction of function name (like yt-dlp/yt-dlp#10390) * always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan)
dirkf
added a commit
to ytdl-org/ytdl-nightly
that referenced
this pull request
Jul 11, 2024
* improve extraction of function name (like yt-dlp/yt-dlp#10390) * always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan)
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Jul 11, 2024
* https://github.com/ytdl-org/youtube-dl: [YouTube] Fix nsig processing for player `b22ef6e7` * improve extraction of function name (like yt-dlp/yt-dlp#10390) * always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan) [jsinterp] Support functionality for player `b22ef6e7` * support `prototype` for call() and apply() (yt-dlp/yt-dlp#10392, thx Grub4k) * map JS `Array` to `list` [jsinterp] Further improve expression parsing (fix fd8242e) Passes tests from yt-dlp [jsinterp] Re-align JSInterp and tests (esp.) with yt-dlp Thx: various yt-dlp authors [core] Address gaps in allowed extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Fixes #10391
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?