Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: remove deprecated IF in Cython #33

Merged
merged 1 commit into from
Mar 22, 2023
Merged

MNT: remove deprecated IF in Cython #33

merged 1 commit into from
Mar 22, 2023

Conversation

neutrinoceros
Copy link
Member

IF is deprecated in Cython 3.0
I am unsure if this conditional is still needed or not, so first I'll submit its removal to CI

@neutrinoceros
Copy link
Member Author

So this survives CI (with windows-latest), but I would still love to get feedback from @jzuhone since I don't know the history of this conditional.

@neutrinoceros neutrinoceros marked this pull request as ready for review March 18, 2023 13:59
@neutrinoceros
Copy link
Member Author

Looks like using an older image (windows-2019) doesn't raise any issue either. I'm still not excluding the possibility that a real error is creeping in undetected, but it seems less likely.

jzuhone
jzuhone approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@jzuhone jzuhone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I do not remember why we needed to do this--it was years ago so I suspect I should not be surprised that it's been handled in the interim, given it seems like a simple thing.

@neutrinoceros
Copy link
Member Author

That's fair, thank you !
Since the added job doesn't seem to provide value, and is significantly more demanding in CI time, I'll just disable it then

@neutrinoceros neutrinoceros merged commit 6d4745e into yt-project:main Mar 22, 2023
@neutrinoceros neutrinoceros deleted the no_cython_IF branch March 22, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzuhone jzuhone jzuhone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoceros @jzuhone