-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for latest versions of h5py, sympy, numpy, and pytest #115
Conversation
this means we will notice when upstream changes cause breakages in our tests, right now we don't notice since tox never recreates virtualenvs
…g new size limits
Do you mean NumPy 1.18? |
Yes, sorry for the typo. |
@ngoldbaum do you want anyone else to have a look at this before merging? |
I was a little worried about the test failures in yt from the changes in this PR. I'm not convinced that the yt failures are something that can't happen with unyt, since unyt's |
This fixes a number of issues caused by updates to upstream libraries we depend on. This is a bit of a grab-bag PR that makes the tests pass again on the latest versions of our dependencies. Unfortunately I can't easily issue these changes as separate PRs since the tests will be broken without all of these coming in at once. If you have questions about reviewing this I'm happy to help out.
To catch issues caused by upstream changes more quickly in the future I've updated the tox config to always recreate a virtualenv. This will ensure we get test failures on the cron job test whenever an upstream release breaks our test suite.
I also made the following updates to our tox config:
coverage
to be older than coverage 5.0, which allows us to work around Coverage in parallel failing nedbat/coveragepy#883There also some code changes, in particular
h5py.open
.rationalize
transformer in our usage ofsympy.parse_expr
. Before we were not using it correctly since we needed to runauto_number
first.out
keyword argument for ufuncs that have multiple outputs.Pint.quantity.__array__
.