-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TVer] insufficient/improper titles for some videos #28418
Closed
5 tasks done
ghost opened this issue
Mar 12, 2021
· 0 comments
· Fixed by rafaelurben/django-discordbot#86, tomy0000000/tubee#15, natanlao/yaas#21, kijk2869/discodo#156 or etnguyen03/docker-tubeup#59
Closed
5 tasks done
[TVer] insufficient/improper titles for some videos #28418
ghost opened this issue
Mar 12, 2021
· 0 comments
· Fixed by rafaelurben/django-discordbot#86, tomy0000000/tubee#15, natanlao/yaas#21, kijk2869/discodo#156 or etnguyen03/docker-tubeup#59
Comments
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this issue
Mar 12, 2021
* https://github.com/ytdl-org/youtube-dl: [pinterest] reduce the number of HLS format requests [peertube] improve thumbnail extraction(closes ytdl-org#28419) [tver] improve title extraction(closes ytdl-org#28418) [fujitv] fix HLS formats extension(closes ytdl-org#28416)
This was referenced Mar 15, 2021
leshasmlesha
pushed a commit
to leshasmlesha/youtube-dl
that referenced
this issue
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Checklist
Verbose log
Example 1.
Example 2.
Description
youtube-dl generates insufficient/improper titles for videos under https://tver.jp/cx .
For the above example 1, the title should be like 'いいすぽ! #114「鉄拳7」', but youtube-dl generates '#114「鉄拳7」' (only the episode part), and for the above example 2, the title should be 'きょうのわんこ', but youtube-dl generates ' ' (only a whitespace).
This line https://github.com/ytdl-org/youtube-dl/blob/master/youtube_dl/extractor/tver.py#L51
'title': main.get('subtitle') or main['title'],
could be improved to something like:if main.get('subtitle') exists and not only whitespaces, then the title should be
main['title'] + delim + main.get('subtitle')
where delim be ' ' (a whitespace) or preferably '\u3000' (IDEOGRAPHIC SPACE), and
if main.get('subtitle') doesn't exist or only whitespaces, then the title should be
main['title']
which improves the above example 1 and 2 accordingly.
The text was updated successfully, but these errors were encountered: