Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Rework test_download to allow running all tests of a single extractor #27461

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oddstr13
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

The goal is being able to run info extractor tests for only a single provider or extractor.
This makes the test usable when maintaining individual providers.

python -m unittest test.test_download.TestDownload.test_nrk runs extractor tests for the contents of extractor/nrk.py.
python -m unittest test.test_download.TestDownload.test_nrk.test_NRKTVEpisode runs extractor tests for NRKTVEpisodeIE.

TODO:

  • Fix running all extractor tests with python test/test_download.py
  • Update documentation

This PR is currently marked as draft because it seems I may have broken running the test with python test/test_download.py
As only a single (erroring) test gets ran then.

Reviews are still welcome, both from maintainers and others with knowledge of python's testing features.

The goal is being able to run info extractor tests for
only a single provider or extractor.
This makes the test usable when maintaining individual providers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant