Fix umg:de as API site no longer resolves #29304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Site now also issues a "master" m3u8 which has the audioonly and video quality options instead of different formats. Updated the script to not rely on the "height" as this m3u8 doesn't have it.
dstftw
requested changes
Jun 16, 2021
youtube_dl/extractor/umg.py
Outdated
| urlh = self._request_webpage(f_url, video_id, fatal=False) | ||
| if urlh: | ||
| first_byte = urlh.read(1) | ||
| if first_byte not in (b'F', b'\x00'): | ||
| continue | ||
| formats.append(fmt) | ||
| if not formats: | ||
| for format_id in (867, 836, 940): | ||
| add_m3u8_format(format_id) |
There was a problem hiding this comment.
That's all correct code [53-93], do not remove it. Fix add_m3u8_format instead.
gaming-hacker
added a commit
to gaming-hacker/youtube-dl
that referenced
this pull request
Sep 3, 2021
* commit '188b7b108e1cd287580bee5dba8075e669c29a10': (192 commits) Avoid skipping ID when unlisted_hash is numeric [peertube] only call description endpoint if necessary (ytdl-org#29383) [periscope] pass referer to HLS requests(closes ytdl-org#29419) [liveleak] Remove extractor (closes ytdl-org#17625, closes ytdl-org#24222) (ytdl-org#29331) [pornhub] Add support for pornhubthbh7ap3u.onion [pornhub] Detect geo restriction [pornhub] Dismiss tbr extracted from download URLs (closes ytdl-org#28927) [curiositystream:collection] Extend _VALID_URL (closes ytdl-org#26326, closes ytdl-org#29117) [youtube] Make get_video_info processing more robust (closes ytdl-org#29333) [youtube] Workaround for get_video_info request (refs ytdl-org#29333) [bilibili] Strip uploader name (ytdl-org#29202) [youtube] Update invidious instance list (ytdl-org#29281) [umg:de] Update GraphQL API URL (ytdl-org#29304) [nrk] Switch psapi URL to https (closes ytdl-org#29344) [postprocessor/ffmpeg] Show ffmpeg output on error (refs ytdl-org#22680) (ytdl-org#29336) [egghead] Add support for app.egghead.io (closes ytdl-org#28404) (ytdl-org#29303) [appleconnect] Fix extraction (ytdl-org#29208) [orf:tvthek] Add support for MPD formats (closes ytdl-org#28672) (ytdl-org#29236) [README.md] Update MSVC 2010 redist URL (closes ytdl-org#29222) release 2021.06.06 ... # Conflicts: # youtube_dl/extractor/generic.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
"api.universal-music.de" no longer resolves, updated to the current URL. Site now also issues a "master" m3u8 which has the audioonly and video quality options instead of different formats. Updated the script to not rely on the "height" as this m3u8 doesn't have it.