-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nate] Add new site #30330
base: master
Are you sure you want to change the base?
[Nate] Add new site #30330
Conversation
已经收到您的来信,谢谢
|
youtube_dl/extractor/nate.py
Outdated
def _real_extract(self, url): | ||
video_id = self._match_id(url) | ||
|
||
video_data = self._download_json('https://tv.nate.com/api/v1/clip/' + str(video_id), video_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or at least, it's not unicode
. In yt-dl str
should almost always be compat_str
, but as above it's not needed here.
I've adapted the yt-dlp code that derived from this PR and updated this PR accordingly, with additional error-handling. The download tests all passed locally. Testers welcome. |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Closes #30236, qv.