-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ciscolive] Fix issues and dynamically fetch tokens #30865
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work!
Also, check and resolve the failing test output (eg Py3.9 Core):
|
Failed tests are now fixed, seems i had left a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I enabled the CI tests. Please check the results (at least Linter and the core and download tests for Py2.7, Py3.10, possibly Py3.5 too -- for the download tests just search the logs for ciscolive).
All we are saying is ...
Some security snafu has broken the web again, so the CI tests are failing (actions/setup-python#866). I'll see if the recommended hack works for the moment... YES! |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
addresses the 3x issues I raised and detailed in #30864
static rainfocus api's in extractor are no longer valid
i have addressed this in the same way the browser does, by fetching the tokens from a js script. It is plausible to only update the static tokens (they have been valid since 2018).
This method may be more useful if the api key updates again, however it equally has the risk of failing if the site javascript dramatically changes.
i have left in the RAINFOCUS_API_PROFILE_ID and RAINFOCUS_WIDGET_ID constants but set them to blank.
If blank the values will be fetched at runtime via a
_download_webpage()
call.In future if somebody wished to quickly patch the extractor they could set these values without needing to debug why the dynamic fetch is failing.
tests no longer pass
testing url's and info_dict have been updated with url's and data that are current and pass the tests.
ciscolive domain has changed
updated Origin to match valid domain, updated regex to no longer permit old domain (
ciscolive.cisco.com
), updated tests with url paths featuring the new domain.added a couple informative
ExtractorError()
these occur when tokens can not be obtained or video playlists are empty (the later can occur in 2 scenarios:I'm conscious the messages on these ExtractorErrors() could be better/shorter.
technical details for each including failing outputs are contained within issue #30864
Relevant working test outputs