-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YouTube] Support @owner format in uploader_id etc #31675
Conversation
Signalled by regexp ID value, eg: `'id': r're:[\da-zA-Z_-]{8,}'`
* implement ytdl-org#31530 (comment) * update affected tests * misc clean-ups
These tests pass locally but not in CI:
Presumably there is some regional difference in the availability of the playlist items, but XFF seems to have no effect. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Starting from a selected commit, there's preparation (eg changelog), and a build step, and a deployment step to make the built versions available. See #31585. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Thank you @dirkf for the fix ! Everything goes fine now :) |
This comment was marked as resolved.
This comment was marked as resolved.
Read #31530. |
Boilerplate: own code, bug fix
## Please follow the guide belowx
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
According to #31530, YouTube has changed its metadata so that the owner URL has the format
.../@ownerslug
rather than.../user/user_id
or.../channel/channel_id
. Some, if not all, music videos retain the previous scheme.This caused several problems:
Proposed final resolution from linked post:
uploader
is the author text valuechannel
is the sameuploader_id
becomes the @... valuechannel_id
ischannelId
uploader_url
is the author URL with /@...channel_url
is/channel/{channel_id}
at least while that is valid.The linked post identifies that these metadata items may be available in various parts of the YT webpage, with slightly different access paths depending on the page type.
Thus, this PR
id
changed.Closes #31568
Resolves #31530