-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nhk] Fix: NhkVod(|Program) Extractor / [Piksel] Feat: Add variable host support #32213
Conversation
_call_api function was using hardcoded hosts
NHK now hosts it's api instead of redirecting to piksel host. Added test. Fixed illegal usage of child class property in base class. Minor Style Issues fixed by PyCharm reformat file.
Honestly, I hope this does not result in nitpicking again! |
- Use correct class inheritance for video / playlist scheme - Move functions according to video / playlist scheme
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
Looks good: I've made some small suggestions for project conventions and robustness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted changes.
Co-authored-by: dirkf <fieldhouse@gmx.net>
Co-authored-by: dirkf <fieldhouse@gmx.net>
To say it bluntly, this code review process did not yield any significant quality improvement. |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
NHK World VOD is broken since a few weeks.
This is due changing to self-hosted API and player instance.
Necessary tweaks were to