Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nhk] Fix: NhkVod(|Program) Extractor / [Piksel] Feat: Add variable host support #32213

Closed
wants to merge 8 commits into from

Conversation

menschel
Copy link

@menschel menschel commented May 19, 2023

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

NHK World VOD is broken since a few weeks.

This is due changing to self-hosted API and player instance.

Necessary tweaks were to

  • make PikselIE use the host of the given URL instead of hard-coded Piksel host.
  • use the correct template url for the initial API call in NhkVodIE

_call_api function was using hardcoded hosts
NHK now hosts it's api instead of redirecting to piksel host.

Added test.
Fixed illegal usage of child class property in base class.
Minor Style Issues fixed by PyCharm reformat file.
@menschel
Copy link
Author

Honestly, I hope this does not result in nitpicking again!
Take it or drop it.

- Use correct class inheritance for video / playlist scheme
- Move functions according to video / playlist scheme
@menschel menschel changed the title [NhkVod] Fix: NhkVod Extractor / [Piksel] Feat: Add variable host support [NhkVod] Fix: NhkVod(|Program) Extractor / [Piksel] Feat: Add variable host support May 20, 2023
@menschel menschel changed the title [NhkVod] Fix: NhkVod(|Program) Extractor / [Piksel] Feat: Add variable host support [Nhk] Fix: NhkVod(|Program) Extractor / [Piksel] Feat: Add variable host support May 20, 2023
@dirkf
Copy link
Contributor

dirkf commented May 26, 2023

... again ??

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

Looks good: I've made some small suggestions for project conventions and robustness.

youtube_dl/extractor/nhk.py Outdated Show resolved Hide resolved
youtube_dl/extractor/piksel.py Outdated Show resolved Hide resolved
youtube_dl/extractor/piksel.py Outdated Show resolved Hide resolved
youtube_dl/extractor/piksel.py Outdated Show resolved Hide resolved
Copy link
Author

@menschel menschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted changes.

Co-authored-by: dirkf <fieldhouse@gmx.net>
@menschel
Copy link
Author

To say it bluntly, this code review process did not yield any significant quality improvement.
It merely wasted 1 week and introduced a flake8 issue along the way.
Solving this simple duplicate import made me realize how Github has slided down in Quality after Micro$oft has taken over Regime. Please move to another platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants