-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 use latest major version for actions/checkout #32672
base: master
Are you sure you want to change the base?
Conversation
What would be useful is to go through the CI here, and in the dependent actions repos here, and in the nightly repo (separate PRs, obvs) changing all uses to v4 **and setting |
Hey @dirkf , are you interested in my PR or should I close it? Can I help in anyway with your CI or what will be done…? 🤔 |
I just love the pointless version dependency hell that is the GH actions ecosystem. Apparently changing to v4 might clear some warnings about node.js versions. Why that needs new major version is far from clear. But we do get the new Then we need to make the equivalent changes in the nightly repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think?
Co-authored-by: dirkf <fieldhouse@gmx.net>
Co-authored-by: dirkf <fieldhouse@gmx.net>
That looks better! But I'm still undecided whether it's appropriate to use To expand on #32672 (comment), in principle it should be enough to use |
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Use latest major version of actions/checkout for GitHub Actions.