[utils,ie] Misc yt-dlp back-ports, etc #32799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove `is_user_input` option per yt-dlp/yt-dlp#8673 * support traversal of compat_xml_etree_ElementTree_Element per yt-dlp/yt-dlp#8911 * allow un/branching using all and any per yt-dlp/yt-dlp#9571 * support traversal of compat_cookies.Morsel and multiple types in `set()` keys per yt-dlp/yt-dlp#9577 thx Grub4k for these * also, move traversal tests to a separate class * allow for unordered dicts in tests for Py<3.7
NB This isn't actually a compat fn; it should be utils.int_from_int_or_char
* add _yes_playlist() method * avoid crash using _NETRC_MACHINE * use _search_json() in _search_nextjs_data() * _search_nextjs_data() default is JSON, not text * test for above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Own/yt-dlp code, Improvement
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
The main object of this PR is to bring
traverse_obj()to par with recent changes in yt-dlp (thx Grub4k for these):is_user_inputoption per [utils]traverse_obj: Moveis_user_inputinto output template yt-dlp/yt-dlp#8673compat_xml_etree_ElementTree_Elementper [utils]traverse_obj: Supportxml.etree.ElementTree.Elementyt-dlp/yt-dlp#8911traverse_obj: Allow unbranching usingallandanyyt-dlp/yt-dlp#9571compat_cookies.Morseland multiple types inset()keys per [utils]traverse_obj: Convenience improvements yt-dlp/yt-dlp#9577To make XML traversal work in Py2.6, a new compat_etree_iterfind is added based on CPython 2.7 code.
To match yt-dlp there is a traversal.py (not yet nested) and separate tests for utils and traversal.
Secondly, some small additional back-ports related to the InfoExtractor API have been provided:
_yes_playlist()method_NETRC_MACHINE_search_json()in_search_nextjs_data()_search_nextjs_data()default is JSON, not text.