[Tube8] Fixed video download and added channel download #32839
Conversation
There was a problem hiding this comment.
Thanks for your good work!
I've had a look at the video extractor and made some suggestions. If you accept the relevant suggestion please include the mentioned mod to common.py -- as a separate commit.
Maybe there is scope to make a base class in the YouPorn module and import the "borrowed" code from there but that doesn't need to be done now.
I'll review the list extractor later if I may.
youtube_dl/extractor/tube8.py
Outdated
| traverse_obj, | ||
| T, | ||
| url_or_none, | ||
| parse_iso8601, | ||
| get_element_by_class, | ||
| get_element_by_id, | ||
| int_or_none, | ||
| str_to_int, | ||
| parse_qs, | ||
| urljoin, |
There was a problem hiding this comment.
Please sort these (case-insensitive, _ sorts first). Obvs also add any other imports implied by accepted changes below.
| 'categories': ['Teen'], | ||
| 'tags': ['dancing'], |
There was a problem hiding this comment.
Seems like these aren't being shown on the test video page. but age_limit must be set and duration is easily available. See comments below.
Co-authored-by: dirkf <fieldhouse@gmx.net>
added age_limit to test changed info thumbnail check
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
The current Version of the Tube8 Extractor is broken. I have changed it so that Videos can be extracted again.
I have also added a function to extract all Videos from a single channel.
Parts, especially for the channel videos, are taken from the YouPorn extractor.